From 3dac3a52e21de598234fd6f5d5f9b4f1b1c7756d Mon Sep 17 00:00:00 2001
From: Erik Burton <erik.burton@smartcontract.com>
Date: Wed, 24 Jan 2024 10:18:59 -0800
Subject: [PATCH] fix: maintain behaviour for parseRunInstall, error messages

---
 dist/index.js             | Bin 635037 -> 635440 bytes
 src/inputs/run-install.ts |  35 +++++++++++++++++++++++------------
 2 files changed, 23 insertions(+), 12 deletions(-)

diff --git a/dist/index.js b/dist/index.js
index 5149cd775a6a2ee75466c3a87426adb8fd5714c5..ba2ca00e74387407cc79c9154767a924b3fe2522 100644
GIT binary patch
delta 722
zcmZvaze^lJ6vy$$xqD(D5SuF`ql9Ayj^RXXa#`aR60Gbj62zO^eR~<%%q%mr>TxUt
zQYeCr2X2*K5J9W7DO36{2>umT88=22Z;LN8@ZS5p@4PoZ@0!>5&FeokpGSC+>rIiQ
zW}C%4#6BU3k^yK<;gB1=Ogaioss!?tVgt%`aoW6({`)Wf&d8l<&6NrH?kA_Q^;82C
z_CXCW*Bip9LD7O_5NjAdWt1ZrNR~yZ2n?43l_U90W8zJIb?nq%;daYfQ%Wj=yJybA
zDn%QI2?Pd0Bzt@I(n7t|puRNd-OvmYkP(8c`}~fG+4iHijyHxHoj9}WC0tL+7?`Ny
zQ3XM&G~XX5pF8a_vPXl1ute5IanY{?+r%-m4;9EZWvZ`BO!l~+O5|f=*3G}KOwW&Q
zPiwD>!idKP6vp7K<-a@i`Ol<dKLZrhMbAq`2oV<$Hk&?;LG;bnwKf?BQfPy~^XWI1
z6vh81ObFeRT;Qb^S|Xj7TUxGki|lItjY5}=7c<S*FQ*zmn0v(B39Ct~DXVF#n$?Vz
MW99y0ZvDf>Un&3fo&W#<

delta 362
zcmdn+L~ZUvwGAg&9m*1OGE)*uQiDqKJoAc65_57q^9o8!G#oXpGt)F2i;5B}^)idW
zG*C>lD7B=tC{MxB8pfE+$)+QY!;s02Y?8id`9&JZ`9Px;92N4@6jC*-F;%<fl@wJ1
zjjydu%_&aBsUTHzI-@m{urR`{5RE`HryF*$D@~TQXP<t-mWg9>8M`QxlICO;cH7Cq
z_JS}md63vuc7y3>4H>zR6^pSZm!|;baySf-)r;{a7Nr*}0i9K=V`OPIInc>yGG9E~
n<bI}t=7n7C3%MA9m<foPftUq|S%H`hh}nUdWBWob&i>^9^9*}v

diff --git a/src/inputs/run-install.ts b/src/inputs/run-install.ts
index 01e9eb8..dcd273a 100644
--- a/src/inputs/run-install.ts
+++ b/src/inputs/run-install.ts
@@ -1,4 +1,4 @@
-import { getInput,InputOptions } from '@actions/core'
+import { getInput, InputOptions, error } from '@actions/core'
 import { parse } from 'yaml'
 
 export interface RunInstall {
@@ -23,35 +23,46 @@ export function parseRunInstall(name: string): RunInstall[] {
   if (!input) return []
   if (input === true) return [{ recursive: true }]
 
-  validateRunInstallInput(input)
+  if (!isInputValid(input)) process.exit(1);
 
   return Array.isArray(input) ? input : [input]
 }
 
-function validateRunInstallInput(input: any) {
+function isInputValid(input: any) {
   if (Array.isArray(input)) {
-    for (const entry of input) {
-      validateRunInstallEntry(entry)
-    }
+    return input.every(isEntryValid)
   } else {
-    validateRunInstallEntry(input)
+    return isEntryValid(input)
   }
 }
 
-function validateRunInstallEntry(input: any) {
+function isEntryValid(input: any): boolean {
   if (typeof input !== 'object') {
-    throw new Error('Invalid input for run_install')
+    error(`Invalid input for run_install. Expected object, but got ${typeof input}`)
+    return false;
   }
 
   if (input.recursive !== undefined && typeof input.recursive !== 'boolean') {
-    throw new Error('Invalid input for run_install.recursive')
+    error(`Invalid input for run_install.recursive. Expected boolean, but got ${typeof input.recursive}`)
+    return false;
   }
 
   if (input.cwd !== undefined && typeof input.cwd !== 'string') {
-    throw new Error('Invalid input for run_install.cwd')
+    error(`Invalid input for run_install.cwd. Expected string, but got ${typeof input.cwd}`)
+    return false;
   }
 
   if (input.args !== undefined && !Array.isArray(input.args)) {
-    throw new Error('Invalid input for run_install.args')
+    error(`Invalid input for run_install.args. Expected array, but got ${typeof input.args}`)
+    return false;
   }
+
+  const invalidArgs: any[] = input.args.filter((arg: any) => typeof arg !== 'string');
+  if (input.args !== undefined && invalidArgs.length > 0) {
+    const invalidArgsMessage = invalidArgs.map((arg: any) => typeof arg).join(', ');
+    error(`Invalid input for run_install.args. Expected array of strings, but got ${invalidArgsMessage}`)
+    return false;
+  }
+
+  return true;
 }