pnpm/action-setup
1
0
Fork 0
mirror of https://github.com/pnpm/action-setup.git synced 2025-04-04 17:59:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: resolve review

Browse Source
This commit is contained in:
Jack Works 2022-02-24 19:05:21 +08:00
parent 5626e8797f
commit f4eb24c57f
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/install-pnpm/run.ts
View File

@ -2,7 +2,7 @@ import { addPath, exportVariable } from '@actions/core'
import fetch from '@pnpm/fetch'
import { spawn } from 'child_process'
import { remove, ensureFile, writeFile, readFile } from 'fs-extra'
import { join } from 'path'
import path from 'path'
import { execPath } from 'process'
import { Inputs } from '../inputs'
@ -11,7 +11,7 @@ export async function runSelfInstaller(inputs: Inputs): Promise<number> {
// prepare self install
await remove(dest)
const pkgJson = join(dest, 'package.json')
const pkgJson = path.join(dest, 'package.json')
await ensureFile(pkgJson)
await writeFile(pkgJson, JSON.stringify({ private: true }))
@ -31,7 +31,7 @@ export async function runSelfInstaller(inputs: Inputs): Promise<number> {
cp.on('close', resolve)
})
if (exitCode === 0) {
const pnpmHome = join(dest, 'node_modules/.bin')
const pnpmHome = path.join(dest, 'node_modules/.bin')
addPath(pnpmHome)
exportVariable('PNPM_HOME', pnpmHome)
}
@ -41,14 +41,15 @@ export async function runSelfInstaller(inputs: Inputs): Promise<number> {
async function readTarget(version?: string | undefined) {
if (version) return `pnpm@${version}`
const workspace = process.env.GITHUB_WORKSPACE
if (!workspace) {
const { GITHUB_WORKSPACE } = process.env
if (!GITHUB_WORKSPACE) {
throw new Error(`No workspace is found.
If you're intended to let this action read pnpm version from the package.json/packageManager field,
please run the actions/checkout before this one, otherwise please specify the version in the action config.`)
If you're intended to let pnpm/action-setup read preferred pnpm version from the "packageManager" field in the package.json file,
please run the actions/checkout before pnpm/action-setup.
Otherwise, please specify the pnpm version in the action configuration.`)
}
const { packageManager } = JSON.parse(await readFile(join(workspace, 'package.json'), 'utf8'))
const { packageManager } = JSON.parse(await readFile(path.join(GITHUB_WORKSPACE, 'package.json'), 'utf8'))
if (typeof packageManager !== 'string') {
throw new Error(`No pnpm version is specified.
Please specify it by one of the following ways: